Fixes a bug preventing rep's disk health check from functioning when run from inside bpm (like it always is run)#1174
Merged
Conversation
BPM containers only see paths explicitly listed as additional_volumes. When diego.rep.disk_health_check_paths is configured, rep's diskcheck runner calls statfs on each path at startup; if any path is absent from the container's mount namespace it gets ENOENT, which the runner treats as unhealthy and triggers immediate evacuation. Loop over disk_health_check_paths in bpm.yml.erb and emit each as a writable additional_volume so BPM mounts the real host path into the container before rep starts. ai-assisted=yes
Mounting root as a BPM additional_volume would expose the entire host filesystem inside the container. Guard against accidental misconfiguration by skipping any path that is exactly "/". ai-assisted=yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the necessary paths as writable mounts inside rep
Backward Compatibility
Breaking Change? no