Add test id to the tmp directory file path - #351
Merged
sergeychernyshev merged 1 commit intoAug 17, 2026
Conversation
sergeychernyshev
self-requested a review
August 17, 2026 17:21
sergeychernyshev
approved these changes
Aug 17, 2026
sergeychernyshev
left a comment
sergeychernyshev
left a comment
Member
There was a problem hiding this comment.
Perfect! I had a nagging feeling that I missed this detail from the past browsing through code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the tmp directory created to store browser context will always use
./tmp, meaning multiple runs of telescope will share it, causing test failures due to the browser not allowing shared directories. Adding the test id means each run will use a separate directory. The directory is deleted on completion of the test, so this won't increase disk usage.