Skip to content

[LOGPUSH] Update Gateway Network SourceInternalIP wording - #33066

Open
tomislavcf wants to merge 1 commit into
cloudflare:productionfrom
tomislavcf:patch-1
Open

[LOGPUSH] Update Gateway Network SourceInternalIP wording#33066
tomislavcf wants to merge 1 commit into
cloudflare:productionfrom
tomislavcf:patch-1

Conversation

@tomislavcf

Copy link
Copy Markdown
Contributor

Updating the SourceInternalIP field description because the current wording says it is only available for GRE/IPsec tunnel on-ramps and represents the local LAN IP. A customer confirmed this is also populated for WARP client (device_client) traffic, where the value represents the WARP CGNAT/internal address rather than the device’s local LAN IP. This change clarifies the field behavior across on-ramp types and avoids customers assuming the field should be empty for WARP traffic.

Fix per merge for Fix Gateway analytics IPv4 byte order

Updating the SourceInternalIP field description because the current wording says it is only available for GRE/IPsec tunnel on-ramps and represents the local LAN IP. A customer confirmed this is also populated for WARP client (device_client) traffic, where the value represents the WARP CGNAT/internal address rather than the device’s local LAN IP. This change clarifies the field behavior across on-ramp types and avoids customers assuming the field should be empty for WARP traffic.
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit d55c0de.

👉 Fix in your agent 👈
Fix the following review findings in PR #33066 (https://github.com/cloudflare/cloudflare-docs/pull/33066).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-42f4b21af2a3 · Generated file edited directly
- **File:** `src/content/docs/logs/logpush/logpush-job/datasets/account/gateway_network.md` line 1
- **Issue:** The file begins with `# Code generator. DO NOT EDIT.`, yet the PR modifies the generated `SourceInternalIP` field description on line 172. Manual edits here risk being overwritten by the next generation pass.
- **Fix:** Confirm the source schema or generator for logpush dataset docs is updated instead (or as well) so this wording change persists.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
logs/logpush/logpush-job/datasets/account/gateway_network.md line 1 Generated file edited directly — The file begins with # Code generator. DO NOT EDIT., yet the PR modifies the generated SourceInternalIP field description on line 172. Manual edits here risk being overwritten by the next generation pass. Fix: Confirm the source schema or generator for logpush dataset docs is updated instead (or as well) so this wording change persists.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants