[DNS] Clarify that assigned nameservers cannot be changed - #33037
Merged
ngayerie merged 3 commits intoAug 28, 2026
Merged
Conversation
ngayerie
requested review from
a team,
SebastiaanYN,
Woutifier,
chreo,
dklbreitling,
esomoza-cf,
hannes-cf,
matildeopbravo,
svenr-cf,
vendemiat and
xofyarg
as code owners
August 26, 2026 11:39
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #33037 (https://github.com/cloudflare/cloudflare-docs/pull/33037).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Style Guide Review
### Warnings (1)
#### SG-4d9408d94024 · Headings — trailing punctuation
- **File:** `src/content/docs/dns/faq.mdx` line 95
- **Issue:** ### Why does my new zone have different nameservers than my other zones?
- **Fix:** Remove the trailing question mark from the heading.
### Suggestions (1)
#### SG-d6a51dc51dd3 · Lists — fewer than three items
- **File:** `src/content/docs/dns/faq.mdx` line 108
- **Issue:** The added options list under "To make future zones share the same nameservers..." contains only two bullet items.
- **Fix:** Convert the two-item list to prose or consolidate the items into a single sentence.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewWarnings (1)
Suggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
hannes-cf
reviewed
Aug 28, 2026
hannes-cf
reviewed
Aug 28, 2026
hannes-cf
reviewed
Aug 28, 2026
hannes-cf
reviewed
Aug 28, 2026
hannes-cf
reviewed
Aug 28, 2026
hannes-cf
reviewed
Aug 28, 2026
hannes-cf
approved these changes
Aug 28, 2026
hannes-cf
left a comment
Collaborator
There was a problem hiding this comment.
Approved, once comments are addressed.
DEE-3776 Common customer question: 'why did my new zone get different nameservers than my other zones, can we reassign it?' The answer is already documented but easy to miss. Small changes to make it more discoverable: - DNS FAQ: new entry 'Why does my new zone have different nameservers than my other zones?' explaining the reasons a new zone can be assigned a different pair (cross-account conflict, prior deletion, parent/child rules, Foundation DNS color rotation) and how to get consistent nameservers via Account custom nameservers or DNS zone defaults. - Nameserver options: replace a plain sentence with a callout that points to the new FAQ entry and to the Nameserver consistency section. - Foundation DNS advanced nameservers: new subsection under Nameservers hosting and assignment that explains why a new zone might get a different color set (blue / gold / orange) and cross-links Account custom nameservers.
- faq.mdx: reword 'a different pair' -> 'different nameservers'; drop 'pair' in the parent/child bullet; use 'set' consistently in the delete-and-re-add caveat. - foundation-dns/advanced-nameservers.mdx: 'The same name is' -> 'The same domain is', matching the FAQ wording. - nameservers/nameserver-options.mdx: replace titled ':::note[...]' with an untitled ':::caution' (per docs convention and given severity); in the adjacent pre-existing caution, replace 'a new pair of nameservers' with 'a new set of nameservers' for wording consistency. Also rebased onto origin/production.
ngayerie
force-pushed
the
ngayerie/dns-nameserver-assignment-guidance
branch
from
August 28, 2026 10:57
b5eb80f to
a2743ad
Compare
hannes-cf
approved these changes
Aug 28, 2026
rpots
pushed a commit
that referenced
this pull request
Aug 28, 2026
* Clarify that assigned nameservers cannot be changed DEE-3776 Common customer question: 'why did my new zone get different nameservers than my other zones, can we reassign it?' The answer is already documented but easy to miss. Small changes to make it more discoverable: - DNS FAQ: new entry 'Why does my new zone have different nameservers than my other zones?' explaining the reasons a new zone can be assigned a different pair (cross-account conflict, prior deletion, parent/child rules, Foundation DNS color rotation) and how to get consistent nameservers via Account custom nameservers or DNS zone defaults. - Nameserver options: replace a plain sentence with a callout that points to the new FAQ entry and to the Nameserver consistency section. - Foundation DNS advanced nameservers: new subsection under Nameservers hosting and assignment that explains why a new zone might get a different color set (blue / gold / orange) and cross-links Account custom nameservers. * Style guide: remove directional word from Nameserver consistency link * Address review feedback from @hannes-cf - faq.mdx: reword 'a different pair' -> 'different nameservers'; drop 'pair' in the parent/child bullet; use 'set' consistently in the delete-and-re-add caveat. - foundation-dns/advanced-nameservers.mdx: 'The same name is' -> 'The same domain is', matching the FAQ wording. - nameservers/nameserver-options.mdx: replace titled ':::note[...]' with an untitled ':::caution' (per docs convention and given severity); in the adjacent pre-existing caution, replace 'a new pair of nameservers' with 'a new set of nameservers' for wording consistency. Also rebased onto origin/production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEE-3776
What
dns/faq.mdx): new entry "Why does my new zone have different nameservers than my other zones?" under the existing## Nameserverssection.dns/nameservers/nameserver-options.mdx): replace a plain sentence in Assignment method with a:::notecallout that points to the new FAQ entry and to the Nameserver consistency section.dns/foundation-dns/advanced-nameservers.mdx): new Consistent assignment across new zones subsection that explains why a new zone might get a different color set (blue/gold/orange) and cross-links Account custom nameservers.Why
Common customer question - Support sees it regularly - "why did my new zone get different nameservers than my other zones, can you reassign it?" The docs already state that assignments cannot be changed after zone creation, but the guidance is buried in prose. This makes the answer easier to find, states the "cannot be changed" rule up front, and points customers to the two supported paths for consistent nameservers across zones (Account custom nameservers on Business/Enterprise, or DNS zone defaults on Enterprise).
Documentation checklist