Skip to content

nodes: skip self.model.to(device_to) walk in unpatch_model on mmap'd weights #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Booyaka101 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

nodes: skip self.model.to(device_to) walk in unpatch_model on mmap'd weights #445

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2489f5c
fix(nodes): restore non-quantized backups locally and skip super's mm…
Booyaka101 May 10, 2026
32414a1
nodes: also zero memory counters and run hook/pin cleanup in unpatch …
Booyaka101 May 27, 2026
b543b78
nodes: replace mirrored unpatch block with explicit off-device weight…
Booyaka101 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,24 @@ def unpatch_model(self, device_to=None, unpatch_weights=True):
patches = getattr(p, "patches", [])
if len(patches) > 0:
p.patches = []
# TODO: Find another way to not unload after patches
return super().unpatch_model(device_to=device_to, unpatch_weights=unpatch_weights)
if device_to is not None and self.model.model_lowvram:
for m in self.model.modules():
comfy.model_patcher.move_weight_functions(m, device_to)
# device_to=None makes base skip its nn.Module.to walk, which touches
# still-mmap'd quantized tensors (#444). The walk below only moves
# tensors that live on another device, so host-resident (possibly
# mmap-backed) memory is read at most, never written or remapped.
# Tracking upstream at Comfy-Org/ComfyUI#14142.
super().unpatch_model(device_to=None, unpatch_weights=unpatch_weights)
if unpatch_weights and device_to is not None:
device_to = torch.device(device_to)
for key, param in list(self.model.named_parameters(remove_duplicate=False)):
if param.device != device_to:
comfy.utils.set_attr_param(self.model, key, param.to(device_to))
for key, buf in list(self.model.named_buffers(remove_duplicate=False)):
if buf.device != device_to:
comfy.utils.set_attr(self.model, key, buf.to(device_to))
self.model.device = device_to


def pin_weight_to_device(self, key):
Expand Down