Fix #1231 and #1235 - #1237
Open
ArthurGodet wants to merge 7 commits into
Open
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
…nto fix/1231_1235
…stance in PerfomanceTest (until PropKnapsackKatriel01 is debugged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1231, it is not a real fix (the propagator causing the issue has only been commented in the IIntConstraintFactory), and a real should probably be found (but it might come in a future Pull Request, when one had time to debug the propagator and make sure it is consistent with the paper it comes from).
For #1235, the idea is, as suggested in the issue, to return an arithm constraint instead of posting it.
Otherwise, this Pull Request mainly assure that no constraints are posted within factories anymore (unless LCG is activated).