Skip to content

[QA-001] Add loading, empty, and error states - #96

Open
chev0004 wants to merge 3 commits into
developfrom
feat/qa-001
Open

[QA-001] Add loading, empty, and error states#96
chev0004 wants to merge 3 commits into
developfrom
feat/qa-001

Conversation

@chev0004

@chev0004 chev0004 commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Outline

Summary

Rounds out data states on real routes: profile, settings, and saved get route-level loading skeletons matching their layouts, the saved page survives a failed load with an actionable retry state, and Storybook gains failed-save stories for the profile and settings forms.


Changes & Enhancements

  • Type of Change:
    • Feature
    • Bugfix
    • Refactor
    • Chore
  • Changes:
    • (Routes):
      • Add loading.tsx skeletons for /profile, /settings, and /saved using the existing shimmer idiom; discovery already streams through its Suspense fallback.
      • The saved page catches load failures and renders an error card with a retry action instead of crashing the route.
    • (Storybook):
      • Add SaveError stories with play assertions for ProfilePage and SettingsPage covering the failed-save banner and preserved dirty state.
    • (i18n):
      • Add saved-page error copy to en and ja.

Page / App Changes

Affected Next.js Routes (Local):

  • /[lang]/profile, /[lang]/settings, /[lang]/saved (loading skeletons)
  • /[lang]/saved (load error state with retry)
Before (Screenshot)
After (Screenshot)

Component / Storybook Changes

Affected Storybook Components (Local):

Before (Screenshot)
After (Screenshot)

Not Doing


Other (Remarks)


Checklists

  • Code is well-documented (comments, JSDoc, etc.).
  • Existing comments were updated as needed.
  • No out-of-scope changes are included.
  • Write TODO comments where future work is required.
  • Removed unnecessary debug code (e.g., console.log, debugger).
  • Self-reviewed and tested locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant