[QA-001] Add loading, empty, and error states - #96
Open
chev0004 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outline
Summary
Rounds out data states on real routes: profile, settings, and saved get route-level loading skeletons matching their layouts, the saved page survives a failed load with an actionable retry state, and Storybook gains failed-save stories for the profile and settings forms.
Changes & Enhancements
loading.tsxskeletons for/profile,/settings, and/savedusing the existing shimmer idiom; discovery already streams through its Suspense fallback.SaveErrorstories with play assertions for ProfilePage and SettingsPage covering the failed-save banner and preserved dirty state.Page / App Changes
Affected Next.js Routes (Local):
Before (Screenshot)
After (Screenshot)
Component / Storybook Changes
Affected Storybook Components (Local):
Before (Screenshot)
After (Screenshot)
Not Doing
Other (Remarks)
Checklists
console.log,debugger).