[NOTIF-002] Add browser push notifications - #95
Open
chev0004 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outline
Summary
Makes the Push Notifications setting real: turning it on asks for browser permission only at that moment, registers a service worker, and stores the push subscription per user; denied permission and unsupported browsers show clear inline states and the toggle stays off.
Changes & Enhancements
push_subscriptionstable keyed by endpoint with per-user cascade.POST /api/push/subscriptionvalidating and upserting the browser subscription, andDELETEremoving all of the user's subscriptions.public/sw.jshandling push display and notification clicks.src/lib/push/client.ts: support detection, permission request, service worker registration, subscribe with the VAPID public key, and unsubscribe.NEXT_PUBLIC_VAPID_PUBLIC_KEYandVAPID_PRIVATE_KEYin.env.example; push reports as unavailable when unset.Page / App Changes
Affected Next.js Routes (Local):
Before (Screenshot)
After (Screenshot)
Component / Storybook Changes
Affected Storybook Components (Local):
Before (Screenshot)
After (Screenshot)
Not Doing
Other (Remarks)
This PR adds a migration numbered 0012 in parallel with other open PRs; whichever merges later needs
drizzle/meta/_journal.jsonreconciled.Checklists
console.log,debugger).