Skip to content

[DEV-008] Catch expression-level hardcoded UI strings - #76

Merged
chev0004 merged 2 commits into
developfrom
feat/dev-008
Jun 22, 2026
Merged

[DEV-008] Catch expression-level hardcoded UI strings#76
chev0004 merged 2 commits into
developfrom
feat/dev-008

Conversation

@chev0004

Copy link
Copy Markdown
Owner

Outline

Summary

Extends the i18n linter to catch user-facing strings hidden inside JavaScript expressions, and localizes the one leak it surfaced in the Dropdown empty state.


Changes & Enhancements

  • Type of Change:
    • Feature
    • Bugfix
    • Refactor
    • Chore
  • Changes:
    • (i18n check):
      • Flag string literals assigned to user-facing object keys (label, description, placeholder, subtitle, heading, tooltip).
      • Flag ternary-rendered fallback copy, excluding class-name and identifier strings (hyphen, slash, bracket, colon) to avoid false positives.
      • Dedupe overlapping matches so a single string is reported once.
    • (dropdown):
      • Localize the Dropdown empty-state copy via a new Dropdown namespace in the en and ja locales.

Page / App Changes

Affected Next.js Routes (Local):

Before (Screenshot)
After (Screenshot)

Component / Storybook Changes

Affected Storybook Components (Local):

Before (Screenshot)
After (Screenshot)

Not Doing


Other (Remarks)


Checklists

  • Code is well-documented (comments, JSDoc, etc.).
  • Existing comments were updated as needed.
  • No out-of-scope changes are included.
  • Write TODO comments where future work is required.
  • Removed unnecessary debug code (e.g., console.log, debugger).
  • Self-reviewed and tested locally.

@chev0004 chev0004 self-assigned this Jun 22, 2026
@chev0004
chev0004 merged commit 1e453ae into develop Jun 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant