[SETTINGS-002] Apply theme and language preferences - #75
Closed
chev0004 wants to merge 6 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outline
Summary
Makes the settings theme and application-language preferences actually drive the app: the theme switches the interface live and persists across refresh, and the language preference navigates to the matching locale and is restored after login.
Changes & Enhancements
ThemeProviderthat applies the theme to<html data-theme>and persists it to apolycord_themecookie and localStorage.Page / App Changes
Affected Next.js Routes (Local):
/[lang]/settings/[lang](theme now applies app-wide)Before (Screenshot)
After (Screenshot)
Settings appearance, dark and light:
Application language limited to shipped locales (Japanese):
Theme applies across the app (discovery in light mode):
Component / Storybook Changes
Affected Storybook Components (Local):
Before (Screenshot)
After (Screenshot)
Not Doing
Other (Remarks)
Checklists
console.log,debugger).