[PROFILE-005] Reuse profile card for onboarding preview - #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outline
Summary
Replaces the bespoke onboarding preview markup with the shared discovery
ProfileCard(variant="preview"), so the onboarding card now matches the profile editor preview and the discovery card, and stops drifting from them as the card evolves.Changes & Enhancements
ProfileCard variant="preview"instead of duplicate card markup.DiscoveryProfile, mirroring the profile editor preview, and convert the availability enum withavailabilityPresetToPattern.previewPrimaryFallbackandpreviewNoTagsOnboarding keys (en, ja).previewPublicandpreviewAvailabilityFallbackOnboarding keys.Page / App Changes
Affected Next.js Routes (Local):
/[lang]/onboardingBefore (Screenshot)
After (Screenshot)
Component / Storybook Changes
Affected Storybook Components (Local):
Before (Screenshot)
After (Screenshot)
Not Doing
Other (Remarks)
Checklists
console.log,debugger).