Skip to content

feat: support postgres schema overrides - #1

Merged
hongzexin merged 8 commits into
mainfrom
codex/internal-prod-deploy
Aug 12, 2026
Merged

feat: support postgres schema overrides#1
hongzexin merged 8 commits into
mainfrom
codex/internal-prod-deploy

Conversation

@hongzexin

Copy link
Copy Markdown

Summary

  • add optional PostgreSQL schema override support for shared-database prod installs
  • wire the schema setting through runtime, migrations, Helm values, and docs
  • add focused unit coverage and openspec change files for the new contract

Validation

  • /tmp/codex-lb-py313/bin/pytest tests/unit/test_db_migrate.py -k "postgres_search_path or ensure_postgres_schema_exists or sync_connection_creates_schema" -q
  • /tmp/codex-lb-py313/bin/pytest tests/unit/test_db_session.py -k postgres -q
  • /tmp/codex-lb-py313/bin/pytest tests/unit/test_durable_bridge_sessions.py -k current_postgres_schemas -q
  • /tmp/codex-lb-py313/bin/pytest tests/unit/test_helm_external_secrets.py -k postgres_schema -q

Source sidechat: 019dc7df-46ed-71f0-84cf-0cb475d1857f

@hongzexin

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b5ef94eba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/db/migrate.py Outdated
Comment thread app/db/migration_url.py Outdated
Comment thread .github/workflows/internal-image.yml Outdated
Address Codex review by scoping migration state and Alembic version tables to the configured schema, quoting PostgreSQL identifiers, and removing the unrelated image publisher from this PR.
@hongzexin

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63737df687

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/db/alembic/env.py
Comment thread app/db/alembic/env.py
Address Codex review by committing schema/search_path setup before Alembic transaction ownership and constraining historical enum catalog probes to the active schema.
@hongzexin

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f6b2a1536

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/db/alembic/versions/20260310_000000_fix_postgresql_enum_value_casing.py Outdated
Address Codex review by resolving historical enum probes through pg_type_is_visible so configured and default search paths both target the actually visible type.
@hongzexin

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50ade0d763

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread deploy/helm/codex-lb/README.md Outdated
Source sidechat: 019dc7df-46ed-71f0-84cf-0cb475d1857f
@hongzexin

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c36aed9b96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/core/config/settings.py Outdated
Comment thread app/db/alembic/env.py
Source sidechat: 019dc7df-46ed-71f0-84cf-0cb475d1857f
@hongzexin

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 5cbd43b610

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@hongzexin
hongzexin merged commit e8ef0a5 into main Aug 12, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant