Skip to content

feature/schemafix - Added missing fields for RepresentativeIndividual - #354

Open
david-ruiz-cko wants to merge 2 commits into
masterfrom
feature/schemas-update
Open

feature/schemafix - Added missing fields for RepresentativeIndividual#354
david-ruiz-cko wants to merge 2 commits into
masterfrom
feature/schemas-update

Conversation

@david-ruiz-cko

@david-ruiz-cko david-ruiz-cko commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces support for new fields and types related to financial statements and individual representative information in the Accounts API v3.0. The main changes include adding models for citizenship, national ID types, and financial statements, updating the RepresentativeIndividual and OnboardSubEntityDocuments classes to use these new models, and enhancing test coverage to reflect these updates.

Accounts API v3.0 Model Additions and Updates:

  • Added the Citizenship class to represent a representative's citizenship or legal status, and updated RepresentativeIndividual to include the citizenships array and national_id_type fields. [1] [2]
  • Added the NationalIdType class as an enum for various types of national identification numbers.
  • Added the FinancialStatements class and FinancialStatementsType enum to model financial statements documents, and updated OnboardSubEntityDocuments to use FinancialStatements instead of Document for the financial_statements field. [1] [2] [3]

Test Enhancements:

  • Updated OnboardEntityRequestSerializationTest to use the new FinancialStatements model in test data. [1] [2]
  • Updated RepresentativeIndividualSerializationTest to test serialization and deserialization of the new citizenships and national_id_type fields. [1] [2] [3]

These changes ensure the codebase is aligned with the Accounts API v3.0 schema and improve test coverage for the new and updated models.

@david-ruiz-cko
david-ruiz-cko requested a review from a team July 27, 2026 11:27
@agent-wall-e

agent-wall-e Bot commented Jul 27, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:All changes are non-destructive additions of new plain data model classes and fields to an existing abstraction, with no new endpoints, external integrations, persisted data classes, auth changes, or background processes introduced.

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 4


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Jul 27, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extensionAll changes are non-destructive additions of new plain data model classes and fields to an existing abstraction, with no new endpoints, external integrations, persisted data classes, auth changes, or background processes introduced. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@david-ruiz-cko david-ruiz-cko changed the title Added missing fields for RepresentativeIndividual feature/schemafix - Added missing fields for RepresentativeIndividual Jul 27, 2026

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The PR adds new plain data-holding classes and properties to an existing model class within the same namespace, is non-destructive, introduces no new endpoints/auth/persistence/external integrations, and is a natural extension of the existing accounts schema.

wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Jul 27, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 8


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Jul 27, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant