feat: Make machine-exec working for che-code editor in ubi-based containers - #748
Conversation
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-748-amd64 |
52a2b13 to
4deab86
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe Docker image now uses the Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-748-amd64 |
…ainers Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
4deab86 to
211db4e
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-748-amd64 |
There was a problem hiding this comment.
FWIW, I tested by just running on UBI 8. Can confirm machine-exec starts without issues :
bash-4.4$ cat /proc/26/cmdline
./machine-exec--url127.0.0.1:3333
bash-4.4$ readlink -f /proc/26/cwd/
/checode/checode-linux-libc/ubi8
bash-4.4$ cat /proc/26/status | grep -i state
State: S (sleeping)
What does this PR do?
nexttag of the machine-exec for themainbranchWhat issues does this PR fix?
How to test this PR?
I used the following links to start a workspace and test
machine-exec:Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folderSummary by CodeRabbit
Summary by CodeRabbit