Skip to content

feat: Make machine-exec working for che-code editor in ubi-based containers - #748

Merged
RomanNikitenko merged 1 commit into
che-incubator:mainfrom
RomanNikitenko:machine-exec-support-ubi-containers
Aug 5, 2026
Merged

feat: Make machine-exec working for che-code editor in ubi-based containers#748
RomanNikitenko merged 1 commit into
che-incubator:mainfrom
RomanNikitenko:machine-exec-support-ubi-containers

Conversation

@RomanNikitenko

@RomanNikitenko RomanNikitenko commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

What issues does this PR fix?

How to test this PR?

I used the following links to start a workspace and test machine-exec:

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes
    • Improved machine-exec startup across supported architectures and runtime assemblies.
    • Ensured the correct executable is selected and launched for each runtime environment.
  • Chores
    • Updated the machine-exec base image to the latest build.
    • Simplified container initialization and removed obsolete executable setup steps.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Click here to review and test in web IDE: Contribute

Comment thread build/dockerfiles/assembly.Dockerfile Outdated
@tolusha

tolusha commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

  • /che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
  • /che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
  • /che-ai-assistant check-pr-test-failures — Analyze failing CI checks, identify root causes, and suggest fixes
  • /che-ai-assistant help — Show this help message

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 35d04219-7361-470e-b650-e686734767e1

📥 Commits

Reviewing files that changed from the base of the PR and between 9961a7d and 211db4e.

📒 Files selected for processing (3)
  • build/dockerfiles/assembly.Dockerfile
  • build/scripts/entrypoint-init-container.sh
  • build/scripts/entrypoint-volume.sh
💤 Files with no reviewable changes (1)
  • build/scripts/entrypoint-init-container.sh
🚧 Files skipped from review as they are similar to previous changes (2)
  • build/scripts/entrypoint-volume.sh
  • build/dockerfiles/assembly.Dockerfile

📝 Walkthrough

Walkthrough

The Docker image now uses the next machine-exec image tag and installs binaries in architecture-specific assembly directories. Container initialization no longer prepares /checode/bin. The volume entrypoint starts ./machine-exec after selecting the runtime assembly and changing the working directory.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: azatsarynnyy, rgrunber, vitaliy-guliy


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 inconclusive)

Check name Status Explanation Resolution
Title check ❌ Error Title exceeds 72-character limit at 75 characters and clearly describes the main change of enabling machine-exec for che-code editor in UBI-based containers. Reduce title to under 72 characters while preserving the core message. Example: 'feat: Enable machine-exec for che-code in UBI containers' (55 characters).
Rebase Rules For Upstream Changes ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

…ainers

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko
RomanNikitenko force-pushed the machine-exec-support-ubi-containers branch from 4deab86 to 211db4e Compare August 5, 2026 15:03
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@RomanNikitenko
RomanNikitenko merged commit 9d00081 into che-incubator:main Aug 5, 2026
14 checks passed
@RomanNikitenko
RomanNikitenko deleted the machine-exec-support-ubi-containers branch August 5, 2026 17:17

@rgrunber rgrunber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I tested by just running on UBI 8. Can confirm machine-exec starts without issues :

bash-4.4$ cat /proc/26/cmdline 
./machine-exec--url127.0.0.1:3333
bash-4.4$ readlink -f /proc/26/cwd/
/checode/checode-linux-libc/ubi8
bash-4.4$ cat /proc/26/status | grep -i state
State:  S (sleeping)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants