fix: reliably complete configuration with progress=1000 or progress=0 - #8627
Merged
Conversation
link2xt
approved these changes
Aug 24, 2026
| // An ongoing process, e.g. a backup import, | ||
| // makes configuration fail without ever contacting a relay. | ||
| let _ongoing = t.alloc_ongoing().await?; | ||
| assert!(t.configure().await.is_err()); |
Collaborator
There was a problem hiding this comment.
Would be better to use add_or_update_transport, otherwise the test will have to be updated when we at some point remove configure. MailPw is also deprecated.
this is meant to help configuration event consumers (Python, UIs) to not hang waiting for configuration outcomes. One test case is added that fails on main.
hpk42
force-pushed
the
hpk/configure-always-reports
branch
from
August 24, 2026 16:43
fc9a8dc to
4b2dfef
Compare
hpk42
enabled auto-merge (rebase)
August 24, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is meant to help configuration event consumers (Python, UIs) to not hang waiting for configuration outcomes.
One test case is added that fails on main.