fix: add migration to reset team_profile

[WofWca]

Closes deltachat/deltachat-desktop#6683.

Unfortunately all profiles that were intentionally created
as "team profiles" will also be reset to be normal profiles.
Since the feature is experimental,
I think it's OK to do this (but surely isn't nice).
At least it's better than having all profiles as team profiles.

People who do actually utilize the feature are either not affected
because we don't run the migration if there are messages
that were created before the buggy Desktop release,
or will have to hack the database,
(as it used to be done originally after
#7694),
or create a new profile.

[hpk42]

this would require a somewhat timely full release round to all stores during various vacations and other things ongoing ... is not ideal as you probably know.

I also wonder how many people last week setup their profile on Desktop first.

Also people might have a desktop 2.59.0 and android 2.60.0, but then upgrading desktop destroys the team-profile again, and vice versa.

All in all, I am not sure if going for "hard reset" really solves more problems in the real world than it might cause.

Sidenote: i don't see much point in using SEMBR in issues and PR descriptions, as it's usually not collaboratively edited. It's more for markdown and docs.

[WofWca]

require a somewhat timely full release round

Not sure what you mean by "timely" here. "Simultaneous"? Good to bring that up, but I don't see how that's required? The migration will run also on backup / second device transfer, and team_profile will eventually get reset on all devices.

during various vacations

We can wait until after vacations.

I also wonder how many people last week setup their profile on Desktop first.

I don't know, but I am guessing that this number is most likely bigger than the number of people who have intentionally created a "team profile" (on all clients).

Sidenote: i don't see much point in using SEMBR in issues and PR descriptions, as it's usually not collaboratively edited. It's more for markdown and docs.

I use it for commit messages, and then just copy-paste to the MR description. I think it's also nice for reading, when I'm required to put line breaks.

[hpk42]

if we roll out a force-reset of team profiles with core 2.59+, it will haunt us for many months, as not all people upgrade their clients immediately, even if we wait the vacations and release on the same day all UIs with your PR merged, and get it to all stores on the same day. People still run mixed Android/iOS/UT/Desktop versions in their multi-device setup etc.

Considering that the only downside of Desktop-2.59.0 is for multi-device installs and then seen-messages are not synchronized (which was a problem for many years of delta chat existence), i don't think it's worth to introduce uncertainty/flakyness over many months now. the failure mode of 2.59.0 is not catastrophic just inconvenient, and re-setting up a new profile and multi-device re-setup a known direct solution. Desktop, however, could do a release that resets team-profile setting if it suspects the profile was created last week, and is single-device. If it is multi-device it could additionally provide a warning. No need for any core changes.

[adbenitez]

to be honest, I would say just push a desktop release with a fix as soon as possible and forget about this, the desktop user base is small and advanced, and it is a recent/empty/small new profile, if anything, just add a check in desktop client checking if the profile is a team profile and add a device message saying something like "due to a bug in the previous release, it is likely that this profile got unintentionally created as an experimental Team Profile, please delete and create a new normal profile if you didn't want to create a Team Profile" or so

[WofWca]

Feel free to close the MR and the issue.