get_db_engine - #449
Open
mcoughlin wants to merge 3 commits into
Open
Conversation
stefanv
reviewed
Aug 4, 2026
| """The SQLAlchemy engine that DBSession is bound to. | ||
|
|
||
| A readable accessor so callers that need a one-off sync Session can write | ||
| ``Session(bind=get_db_engine())`` instead of reaching into |
Contributor
There was a problem hiding this comment.
Looks good to me. Quick q: if this really is the intent, then should we just have a utility function for providing the session?
stefanv
reviewed
Aug 4, 2026
| @@ -199,6 +199,9 @@ def bulk_verify(mode, collection, accessor): | |||
Contributor
There was a problem hiding this comment.
I didn't see this come in: what is RLS?
Collaborator
Author
There was a problem hiding this comment.
just access control.
| DBSession.configure(bind=conn, autoflush=autoflush, future=True) | ||
| Base.metadata.bind = conn | ||
|
|
||
| global plain_session_factory |
Contributor
There was a problem hiding this comment.
LGTM; any race conditions to check for?
Collaborator
Author
There was a problem hiding this comment.
each session should be independent, so I don't think so.
Collaborator
Author
|
@stefanv feel free to merge if you are happy with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a get_db_engine helper function.