csi: update kubernetes-csi-addons to v0.15.0 and migrate to CSI v1.13.0 - #6547
Draft
cynthiaantonyj wants to merge 2 commits into
Draft
csi: update kubernetes-csi-addons to v0.15.0 and migrate to CSI v1.13.0#6547cynthiaantonyj wants to merge 2 commits into
cynthiaantonyj wants to merge 2 commits into
Conversation
Updated github.com/csi-addons/kubernetes-csi-addons from v0.14.0 to v0.15.0. Also updated github.com/container-storage-interface/spec from v1.12.0 to v1.13.0 as required by kubernetes-csi-addons v0.15.0, along with the related transitive dependency refreshes Signed-off-by: Cynthia Antony J <cynthiaantonyj@ibm.com>
CSI spec v1.13.0 replaced VolumeCondition in NodeGetVolumeStatsResponse with a dedicated NodeGetVolumeHealth RPC. This commit implements the new API while maintaining volume health monitoring feature parity. Changes: - Remove deprecated VolumeCondition field from NodeGetVolumeStatsResponse - Remove NodeServiceCapability_RPC_VOLUME_CONDITION capability - Implement NodeGetVolumeHealth RPC for RBD, CephFS, and NFS - Add NodeServiceCapability_RPC_GET_VOLUME_HEALTH capability - Reuse existing health-checker infrastructure Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Cynthia Antony J <cynthiaantonyj@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR updates the
kubernetes-csi-addonsv0.15.0 and migrates ceph-csi to use the CSI spec v1.13.0 volume health API.The change consists of two commits:
Commit 1: Dependency update
github.com/container-storage-interface/specfrom v1.12.0 to v1.13.0 (required by csi-addons v0.15.0)go-logr/logr(v1.4.3 → v1.4.4) andgo.uber.org/zap(v1.27.1 → v1.28.0)Commit 2: CSI v1.13.0 API migration
VolumeConditionfield fromNodeGetVolumeStatsResponseNodeServiceCapability_RPC_VOLUME_CONDITIONcapabilityNodeGetVolumeHealthRPC for all three drivers (RBD, CephFS, NFS)NodeServiceCapability_RPC_GET_VOLUME_HEALTHcapabilityIs there anything that requires special attention
CSI Spec API Change
CSI spec v1.13.0 deprecated the
VolumeConditionfield inNodeGetVolumeStatsResponseand introduced a dedicatedNodeGetVolumeHealthRPC for volume health reporting.References:
Implementation Details
The new
NodeGetVolumeHealthRPC:volume_idand volume path (volume_publish_pathorstaging_target_path)health-checker.IsHealthy()infrastructure (no behavior change)VolumeHealthwith:health_statusesarray when volume is healthy (no adverse conditions)VolumeHealthErrorType_INACCESSIBLEstatus with error message when unhealthyReference:
Why This Change is Required
The
kubernetes-csi-addonsv0.15.0 update is needed to:References:
https://github.com/csi-addons/kubernetes-csi-aL8
Checklist:
Testing Performed
make containerized-buildmake containerized-testShow available bot commands
These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelated failure (please report the failure too!)