fix(ledger): iterate account indexes in ledgerLiveMode - #797
Open
Steve0x2a wants to merge 1 commit into
Open
Conversation
--ledgerLiveMode iterated the BIP-44 change component, producing m/44'/60'/0'/N/0 instead of Ledger Live's m/44'/60'/N'/0/0. Add accountIndexes to @celo/wallet-ledger and @celo/viem-account-ledger and wire --ledgerLiveMode to iterate the hardened account index. Fixes celo-org#789 Signed-off-by: Yi Zhan <stevesough@gmail.com>
🦋 Changeset detectedLatest commit: c7e33f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--ledgerLiveModeiterated the BIP-44 change index (m/44'/60'/0'/N/0) instead of the hardened account index that Ledger Live uses (m/44'/60'/N'/0/0). Only the first Ledger Live account was discoverable.This adds
accountIndexesto@celo/wallet-ledgerand@celo/viem-account-ledger, and wires--ledgerLiveModeto:accountIndexes: indicesToIterateOverchangeIndexes: [0]derivationPathIndexes: [0]Non-live
--useLedgerbehavior is unchanged.Credits @palango for the report, the file/line analysis, and the suggested API.
Tested
@celo/wallet-ledgerunit tests: account indexes 0, 1, and 2 produce44'/60'/N'/0/0(index ≥1 distinguishes the bug from iterating change). OmittingaccountIndexesstill uses the account from the base path. Existing change/address iteration is unchanged.@celo/viem-account-ledgerunit tests: the same path construction viaderiveLedgerAccountsandledgerToWalletClient.base.test.tslive-mode expectations now passaccountIndexesinstead ofchangeIndexes.Related issues