Skip to content

Fix deterministic convergence report test clock - #789

Merged
cbusillo merged 4 commits into
mainfrom
code/issue-634-convergence-report-clock
Aug 23, 2026
Merged

Fix deterministic convergence report test clock#789
cbusillo merged 4 commits into
mainfrom
code/issue-634-convergence-report-clock

Conversation

@cbusillo

Copy link
Copy Markdown
Owner

Why

The compact-artifact test uses fixed August 22 timestamps but allowed the report entry point to read the wall clock. Once those fixtures crossed the production freshness thresholds, the test began emitting alerts and blocking unrelated pull requests.

Related to #634.

What changed

  • Wrap the report module's datetime dependency in the existing test.
  • Return the existing fixed NOW from datetime.now() while preserving real datetime.fromisoformat() behavior.
  • Leave production report behavior, thresholds, workflow scheduling, and fixtures unchanged.

Validation

  • python3 -m unittest test_upstream_convergence_report.TestUpstreamConvergenceReport.test_main_writes_compact_artifact
  • python3 -m unittest discover -s .github/scripts -p 'test_*.py' (309 tests)

@cbusillo
cbusillo merged commit 9e5acad into main Aug 23, 2026
19 checks passed
@cbusillo
cbusillo deleted the code/issue-634-convergence-report-clock branch August 23, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants