Fix deterministic convergence report test clock - #789
Merged
Conversation
12 tasks
…e-790-sdk-broken-pipe
Silence expected Python SDK harness disconnects
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The compact-artifact test uses fixed August 22 timestamps but allowed the report entry point to read the wall clock. Once those fixtures crossed the production freshness thresholds, the test began emitting alerts and blocking unrelated pull requests.
Related to #634.
What changed
datetimedependency in the existing test.NOWfromdatetime.now()while preserving realdatetime.fromisoformat()behavior.Validation
python3 -m unittest test_upstream_convergence_report.TestUpstreamConvergenceReport.test_main_writes_compact_artifactpython3 -m unittest discover -s .github/scripts -p 'test_*.py'(309 tests)