fix(benchmarks): skip benchmark tests without pytest-codspeed - #63
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 866 866
Branches 150 150
=========================================
Hits 866 866 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the benchmark suite failing when pytest-codspeed is not installed, e.g. when conda-forge runs pytest tests/ against the sdist.
tests/benchmarks/was added in 0.3.3. Its tests request the benchmark fixture (provided only by pytest-codspeed) and use @pytest.mark.benchmark, a marker the plugin registers. The old skip logic in tests/benchmarks/conftest.py only ran when the plugin was importable and silently did nothing otherwise. Without the plugin, pytest tests/ aborted with PytestUnknownMarkWarning for the unregistered benchmark mark (escalated to an error by filterwarnings = ["error"]) and fixture 'benchmark' not found.register benchmark / codspeed_benchmark markers in pytest_configure when not already present.
identify benchmark tests by the benchmark fixture in item.fixturenames (same check the plugin uses) instead of importing the plugin, so skipping works with or without pytest-codspeed