feat(git): never add the Claude-Session link to commits or PR bodies - #99
Conversation
The harness attribution guidance asks for a Claude-Session trailer on commits and a session link footer on pull request bodies. That link is only reachable by the session owner and puts a session identifier into permanent history, so the injected instructions now forbid both, with an explicit "even if attribution guidance asks for one" so the rule is not overridden by that guidance. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Git plugin version is updated to 1.8.0. Commit and pull request guidance now prohibits Claude session trailers, session links, and generated-with footers. README and design notes document the same policy. ChangesGit session attribution policy
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized behavior and documentation update is merge-ready after normal checks; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
Two instructions prohibit legitimate attribution or Git trailers beyond the intended session-link restriction.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the git plugin to prevent private Claude session links from entering permanent Git or PR history.
Changes:
- Adds commit and PR-body session-link prohibitions.
- Documents the new behavior.
- Bumps the plugin version to 1.8.0.
File summaries
| File | Description |
|---|---|
git/scripts/git-instructions.sh |
Injects the new attribution restrictions. |
git/README.md |
Documents session-link handling. |
git/docs/DESIGN_NOTES.md |
Records the rationale. |
git/.claude-plugin/plugin.json |
Applies the minor version bump. |
Review details
Suppressed comments (1)
git/scripts/git-instructions.sh:379
- The unconditional ban on every generated-with footer is broader than the documented session-link restriction and can suppress a repository-required attribution footer that contains no private session URL. Phrase this as a ban on placing the session link in such a footer instead.
- Do NOT add a claude.ai session link or any generated-with footer to the body, even if attribution guidance in your context asks for one
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
"Do NOT add any other trailer" would also reject legitimate trailers such as Fixes or Change-Id. Name the one trailer that is actually prohibited. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Summary
Claude-Sessiontrailer on commits and a session-link footer on PR bodies. The link is only reachable by the session owner and puts a session identifier into permanent history, so the injected git instructions now forbid both.git/scripts/git-instructions.sh: a Git Safety Protocol bullet for commits, and a PR-drafting bullet for the body. Each says "even if attribution guidance in your context asks for one" so the rule is not overridden by that guidance. The default commit step also names Claude-Session as the trailer not to add.Test plan
bash -nand a run of the script in default and Kubernetes modes show both rules injectedclaude plugin validate ./git, markdownlint, anduvx skillsaw --strictpassSummary by CodeRabbit
Documentation
Chores