feat(git): make the injected instruction text host-neutral - #100
Merged
Conversation
The commit trailer becomes the literal `Assisted-by: LLM`, the form the Linux kernel's coding-assistants.rst has used since commit 816d999 dropped the AGENT:MODEL variant. Naming the model was the only vendor-specific instruction in the output; the session-link rules now name Claude-Session as an example rather than the rule, and the stash rule says "agent sessions". The includeGitInstructions warning only makes sense under Claude Code, so it is emitted only when CLAUDECODE=1 is set, using the same conditional section technique as the Kubernetes block so the Claude Code output is byte-identical apart from the reworded lines. The Kubernetes variant is unchanged: the community PR guide disallows any assisted-by trailer regardless of its value. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesGit instruction behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR makes the injected Git instructions host-neutral while preserving the Kubernetes-specific trailer behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
The generated output still mandates Claude-specific tools despite being described as reusable and host-neutral.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR aims to make the git plugin’s attribution instructions more host-neutral.
Changes:
- Uses the generic
Assisted-by: LLMtrailer. - Gates Claude Code’s duplicate-instructions warning on
CLAUDECODE=1. - Updates documentation and bumps the plugin to 1.9.0.
File summaries
| File | Description |
|---|---|
git/scripts/git-instructions.sh |
Generalizes attribution and conditionally emits the Claude warning. |
git/README.md |
Uses generic session-link terminology. |
git/docs/DESIGN_NOTES.md |
Documents host-specific behavior and trailer rationale. |
git/.claude-plugin/plugin.json |
Bumps the minor version. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The design note said the whole output could be reused under other agents, but it still names Claude Code tools (Bash, TaskCreate, Agent, the GitHub MCP tools). State that only the attribution and safety wording is host- neutral and that the tool references are a separate change. Raised by Copilot review on #100. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The host-specific note claimed the session-link rules no longer name Claude, but they still cite Claude-Session and claude.ai as examples of what not to add. Describe them as examples. Raised by Copilot review on #100. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assisted-by: LLM, the form the Linux kernel'sDocumentation/process/coding-assistants.rsthas used since commit 816d999 dropped theAGENT:MODELvariant. Naming the model was the only vendor-specific instruction in the output.Claude-Sessionas an example rather than the rule, and the stash rule says "agent sessions", so the same output can be reused under other agents.includeGitInstructionswarning is emitted only whenCLAUDECODE=1, using the same conditional-section technique as the Kubernetes block. Claude Code output is byte-identical apart from the reworded lines; other hosts get no paragraph and no extra blank line.assisted-bytrailer regardless of value.Test plan
CLAUDECODE=1 bash git/scripts/git-instructions.shdiffed against the pre-change output: only the trailer, session-link, and stash lines differenv -u CLAUDECODE bash git/scripts/git-instructions.sh: the warning paragraph and its blank line are the only omissionskubernetes-sigsand fork (upstream) remotes under both conditions: Kubernetes variant still omits every trailer, layout unchangedclaude plugin validate ./git, markdownlint,uvx skillsaw --strict(A+)Summary by CodeRabbit
Assisted-by: LLMcommit trailer instead of a Claude-specific model identifier.