Allow users to provide table names as pathlib.Path objects - #295
Merged
Conversation
gmloose
reviewed
Aug 18, 2026
gmloose
left a comment
gmloose
left a comment
Collaborator
There was a problem hiding this comment.
I have some remarks. See above.
Contributor
Author
|
@gmloose thanks for the review! Please let me know how you think I should proceed with each individual note, hopefully the rationale for each of them is clearer now. |
Collaborator
If you could follow up on the suggestion here, I think you're good to go. You can ignore the comments about the local import and the use of a context manager in the test. |
rtobar
force-pushed
the
tablename-as-path
branch
from
August 19, 2026 10:48
0e8c67d to
9d999c1
Compare
gmloose
reviewed
Aug 19, 2026
gmloose
left a comment
gmloose
left a comment
Collaborator
There was a problem hiding this comment.
Just one more thing. I spotted a typo (see comment).
Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
rtobar
force-pushed
the
tablename-as-path
branch
from
August 19, 2026 14:40
9d999c1 to
e38c951
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a few codebases we use
pathlib.Pathobjects for denoting paths in the filesystem. Howeverpython-casacorestringly requires astrfor itstablenamearguments throughout. This PR adds support for providing table names aspathlib.Pathobjects.