ci: Remove D-Bus installation - #5828
Merged
Merged
Conversation
An apt install of dbus-x11 and upower was added in October 2025 to reduce Percy instability, bundled in one commit with a Monaco test waiter and a Percy config change. Every Percy cause diagnosed since has been somewhere else — a module-level panel-width singleton, the discovery browser's font cache — so whether these packages still earn their place has never been tested. They are not free. This is the last apt call left in the workflow, and so the only remaining reason Ubuntu's mirrors sit on its critical path. upower alone brings six dependencies, four of them iOS device libraries, so that a headless runner can report the battery level of a phone that is not attached. The tests still run under `dbus-run-session`. If the image does not provide it the step fails immediately with a command-not-found rather than hanging, so this is inexpensive to be wrong about; the probe that replaces the install records what the image actually ships either way. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
backspace
marked this pull request as ready for review
August 20, 2026 00:25
Contributor
Preview deploymentsHost Test Results 1 files ± 0 1 suites ±0 1h 49m 28s ⏱️ - 18m 10s Results for commit eaf82b3. ± Comparison against earlier commit 91556d6. Realm Server Test Results 1 files ±0 1 suites ±0 14m 10s ⏱️ -2s Results for commit 91556d6. ± Comparison against earlier commit 9f8e66e. |
Percy only runs when a pull request touches packages/host, boxel-ui, boxel-icons, base or runtime-common. This branch changes a workflow file alone, so Percy was skipped — and since the D-Bus helpers were installed specifically to reduce Percy instability, the first green run validated everything except the thing the experiment exists to test. A comment in the host README flips that gate without altering behaviour, and without matching the narrower render-path list that would also force a from-scratch index. Remove before merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The previous run's Percy result was inconclusive, so this takes another sample of the same tree. No content change.
The previous two builds reported differing counts of visual changes on an identical tree. Those snapshots have since been accepted, so this samples the same tree once more: a clean build means the earlier counts were baseline drift rather than run-to-run variance. No content change.
The previous build was clean against the accepted baseline. This repeats it on the same tree to confirm that was stable rather than a single friendly comparison. No content change.
jurgenwerk
approved these changes
Aug 20, 2026
It existed only to bring Percy into this branch's runs, by making the pull request touch a path Percy gates on. Percy has now been sampled four times against an identical tree and reported three changes, then four, then none, then one — so it cannot attribute anything to this change in either direction, and further samples would characterise Percy rather than the removal. What the runs did establish stands on its own: dbus-run-session is already on the runner image via dbus-bin, upower is unnecessary, and the host suite is green across every sample. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an attempt at Percy stability that didn’t really help and just wastes setup time.