Skip to content

BXL indexing-correctness tests and realm-server node smoke suite #5806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
habdelra wants to merge 4 commits into
base: main
Choose a base branch
from
Open

BXL indexing-correctness tests and realm-server node smoke suite #5806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c6bf22
Cover BXL indexing correctness and node isomorphism
habdelra Aug 18, 2026
703ed32
Trigger the host suite on BXL changes too
habdelra Aug 18, 2026
3e68b24
Say what the null-tolerance tests actually exercise
habdelra Aug 18, 2026
4b810f4
Merge remote-tracking branch 'origin/main' into cs-12504-bxl-indexing…
habdelra Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-host.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
- "packages/base/**"
- "packages/boxel-icons/**"
- "packages/boxel-ui/**"
- "packages/bxl/**"
- "packages/eslint-plugin-boxel/**"
- "packages/realm-server/**"
- "packages/runtime-common/**"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ jobs:
- 'packages/base/**'
- 'packages/boxel-icons/**'
- 'packages/boxel-ui/**'
- 'packages/bxl/**'

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Trigger the actual host-test workflow for BXL changes

Adding packages/bxl/** to this boxel filter does not run the new host integration suite: the actual host-test job lives in .github/workflows/ci-host.yaml, whose pull_request.paths list (lines 8–18) still omits packages/bxl/**. Consequently, a future BXL-only PR triggers the standalone BXL and realm-server suites but never executes bxl-indexing-test.gts, leaving the cross-package indexing regressions this commit intends to catch untested; add BXL to the CI Host workflow trigger as well.

Useful? React with 👍 / 👎.

@habdelra habdelra Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Claude Code 🤖] Correct — the boxel output in ci.yaml only gates test-web-assets and the main-branch deploy; the host-test shards live in ci-host.yaml behind its own paths list. A BXL-only change would have run the bxl and realm-server suites and skipped the host indexing suite entirely.

packages/bxl/** added to ci-host.yaml's paths in 703ed32. Leaving the matrix filter alone: those e2e flows don't exercise BXL cards, and the only way a BXL change breaks them is by breaking the host build, which host-test already catches.

- 'packages/host/**'
- 'packages/realm-server/**'
- 'packages/test-realm-cards/**'
Expand Down Expand Up @@ -119,6 +120,7 @@ jobs:
- 'packages/billing/**'
- 'packages/boxel-icons/**'
- 'packages/boxel-ui/**'
- 'packages/bxl/**'
- 'packages/host/**'
- 'packages/eslint-plugin-boxel/**'
- 'packages/postgres/**'
Expand Down
11 changes: 7 additions & 4 deletions packages/host/tests/helpers/cards/bxl-tracking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,11 @@ export const bxlTrackingCardSource = `
// realm's first-ever index pass the live index is empty, so POL-100's
// claims aggregations bake in their empty-set values; the next visit of
// the policy converges them. Tests that assert converged aggregations
// re-write POL-100 with `bxlTrackingPol100Renewal` to trigger that visit.
function pol100Doc(policyStatus: string) {
// re-write POL-100 with `bxlTrackingPol100Renewal` to trigger that visit;
// a test needing more than one such visit builds its own docs with
// `bxlTrackingPol100Doc`, since a re-write of identical content is a
// no-op.
export function bxlTrackingPol100Doc(policyStatus: string) {
return {
data: {
type: 'card',
Expand All @@ -277,7 +280,7 @@ function pol100Doc(policyStatus: string) {
};
}

export const bxlTrackingPol100Renewal = pol100Doc('Renewed');
export const bxlTrackingPol100Renewal = bxlTrackingPol100Doc('Renewed');

export const bxlTrackingRealmContents: Record<
string,
Expand Down Expand Up @@ -364,7 +367,7 @@ export const bxlTrackingRealmContents: Record<
},
},
},
'Policy/pol-100.json': pol100Doc('Active'),
'Policy/pol-100.json': bxlTrackingPol100Doc('Active'),
'Policy/pol-200.json': {
data: {
type: 'card',
Expand Down
Loading
Loading