Skip to content

Improve workspace-chooser notification - #5790

Open
burieberry wants to merge 1 commit into
ai-assistant-panel-design-polishfrom
cs-12517-workspace-chooser-notice-polish
Open

Improve workspace-chooser notification#5790
burieberry wants to merge 1 commit into
ai-assistant-panel-design-polishfrom
cs-12517-workspace-chooser-notice-polish

Conversation

@burieberry

@burieberry burieberry commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Follow up on #5728

Polish/fix UI for workspace-chooser notification.

Trying to fetch (forced ui state screenshot):
in-progress

Could not fetch:
error

Other changes:

  • Failure and Warning Icons: make icon sizing follow lucide icon conventions and optimize svg files.
  • Add @size variable for loading indicator component
  • Update alert component to use the new icons

@burieberry
burieberry changed the base branch from main to ai-assistant-panel-design-polish August 14, 2026 20:59
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Preview deployments

Host Test Results

    1 files      1 suites   1h 43m 0s ⏱️
3 273 tests 3 265 ✅ 7 💤 0 ❌ 1 🔥
3 287 runs  3 278 ✅ 7 💤 1 ❌ 1 🔥

Results for commit e389744.

For more details on these errors, see this check.

Realm Server Test Results

    1 files  ±0      1 suites  ±0   15m 45s ⏱️ + 1m 22s
2 174 tests ±0  2 174 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 254 runs  ±0  2 254 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 05dbd76. ± Comparison against earlier commit 15e5032.

@burieberry burieberry changed the title Cs 12517 workspace chooser notice polish Improve workspace-chooser notification Aug 14, 2026
@burieberry
burieberry force-pushed the cs-12517-workspace-chooser-notice-polish branch from ea4d286 to 46b4c32 Compare August 14, 2026 21:11
@burieberry
burieberry marked this pull request as ready for review August 14, 2026 21:12

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46b4c32e8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/boxel-ui/src/components/loading-indicator/index.gts Outdated
Comment thread packages/host/app/components/operator-mode/workspace-chooser/index.gts Outdated
@burieberry
burieberry force-pushed the cs-12517-workspace-chooser-notice-polish branch 3 times, most recently from 74dbbf4 to 16a1468 Compare August 17, 2026 22:30
@burieberry
burieberry requested a review from a team August 17, 2026 23:29
@habdelra
habdelra requested a lite review from Copilot August 18, 2026 00:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the operator-mode workspace chooser’s “unreachable realm servers” notification by improving messaging and adding UI affordances (icon + spinner), and follows through on related Boxel UI icon/loading-indicator updates.

Changes:

  • Add a MatrixService.isRetryingUnreachableRealmServers getter to drive updated notice wording and UI state.
  • Update workspace-chooser notice to switch icon + text based on retry state, and show a loading spinner while retrying.
  • Refresh warning/failure icons and update LoadingIndicator to support @size; adjust Alert to use the updated icons/sizing.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/host/app/services/matrix-service.ts Exposes retry-loop running state for UI consumers.
packages/host/app/components/operator-mode/workspace-chooser/index.gts Updates unreachable-servers notice copy, icon, and spinner based on retry state.
packages/boxel-ui/src/icons/warning-triangle-filled.gts Updates icon styling to use CSS variables for colors.
packages/boxel-ui/src/icons/failure-bordered.gts Updates icon sizing/viewBox and color variable conventions.
packages/boxel-ui/src/components/loading-indicator/index.gts Adds @size support and simplifies styling/variant handling.
packages/boxel-ui/src/components/loading-indicator/usage.gts Updates Freestyle usage page to document new args.
packages/boxel-ui/src/components/alert/index.gts Adjusts icon sizing/markup to align with updated icons.
packages/boxel-ui/raw-icons/warning-triangle-filled.svg Optimizes raw SVG source.
packages/boxel-ui/raw-icons/failure-bordered.svg Optimizes raw SVG source and updates size/viewBox.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/boxel-ui/src/icons/failure-bordered.gts
Comment thread packages/boxel-ui/src/components/loading-indicator/usage.gts
@burieberry
burieberry force-pushed the cs-12517-workspace-chooser-notice-polish branch from 9bf6e61 to e389744 Compare August 18, 2026 14:59
@lukemelia

Copy link
Copy Markdown
Contributor

Approved once green

@burieberry
burieberry force-pushed the cs-12517-workspace-chooser-notice-polish branch from e389744 to 1bd81de Compare August 18, 2026 16:29
@burieberry burieberry closed this Aug 18, 2026
@burieberry
burieberry force-pushed the cs-12517-workspace-chooser-notice-polish branch from 1bd81de to 15e5032 Compare August 18, 2026 18:06
@burieberry burieberry reopened this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants