Improve workspace-chooser notification - #5790
Conversation
Preview deploymentsHost Test Results 1 files 1 suites 1h 43m 0s ⏱️ Results for commit e389744. For more details on these errors, see this check. Realm Server Test Results 1 files ±0 1 suites ±0 15m 45s ⏱️ + 1m 22s Results for commit 05dbd76. ± Comparison against earlier commit 15e5032. |
ea4d286 to
46b4c32
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46b4c32e8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
74dbbf4 to
16a1468
Compare
There was a problem hiding this comment.
Pull request overview
This PR refines the operator-mode workspace chooser’s “unreachable realm servers” notification by improving messaging and adding UI affordances (icon + spinner), and follows through on related Boxel UI icon/loading-indicator updates.
Changes:
- Add a
MatrixService.isRetryingUnreachableRealmServersgetter to drive updated notice wording and UI state. - Update workspace-chooser notice to switch icon + text based on retry state, and show a loading spinner while retrying.
- Refresh warning/failure icons and update LoadingIndicator to support
@size; adjust Alert to use the updated icons/sizing.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/host/app/services/matrix-service.ts | Exposes retry-loop running state for UI consumers. |
| packages/host/app/components/operator-mode/workspace-chooser/index.gts | Updates unreachable-servers notice copy, icon, and spinner based on retry state. |
| packages/boxel-ui/src/icons/warning-triangle-filled.gts | Updates icon styling to use CSS variables for colors. |
| packages/boxel-ui/src/icons/failure-bordered.gts | Updates icon sizing/viewBox and color variable conventions. |
| packages/boxel-ui/src/components/loading-indicator/index.gts | Adds @size support and simplifies styling/variant handling. |
| packages/boxel-ui/src/components/loading-indicator/usage.gts | Updates Freestyle usage page to document new args. |
| packages/boxel-ui/src/components/alert/index.gts | Adjusts icon sizing/markup to align with updated icons. |
| packages/boxel-ui/raw-icons/warning-triangle-filled.svg | Optimizes raw SVG source. |
| packages/boxel-ui/raw-icons/failure-bordered.svg | Optimizes raw SVG source and updates size/viewBox. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
9bf6e61 to
e389744
Compare
|
Approved once green |
e389744 to
1bd81de
Compare
1bd81de to
15e5032
Compare
…ons and loading indicator
Follow up on #5728
Polish/fix UI for workspace-chooser notification.
Trying to fetch (forced ui state screenshot):

Could not fetch:

Other changes:
@sizevariable for loading indicator component