Fix references to @cardstack/base - #113
Merged
Merged
Conversation
`@cardstack/base/` is the canonical prefix for base-realm modules. The URL spelling `https://cardstack.com/base/` still resolves at runtime, but these docs are where the assistant learns import paths from, so every import position, prose mention, table entry and `.gts` example uses the prefix. Cardinal rule 8 keeps the URL form where it names the thing you must not fetch — `cardstack.com` is a marketing site that answers with a Webflow 404 — and states the prefix as canonical. The linked-to-me pattern's stack-trace sample keeps the URL because that is what the runtime prints. Two markdown links whose href was the module URL become plain code spans: a module reference is not a fetchable address, so linking it invited exactly the GET that rule 8 forbids. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The skill cards' `adoptsFrom.module` refs and their `cardInfo.theme` links use the canonical `@cardstack/base/` prefix. Prefix form is what the index resolves and stores relationship ids in, so the served documents already speak it; the on-disk cards now match. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Staging Workspace Sync SuccessfulSuccessfully synced changes to staging workspace Sync Details |
backspace
changed the title
@cardstack/base@cardstack/base
habdelra
reviewed
Aug 12, 2026
habdelra
left a comment
habdelra
left a comment
Contributor
There was a problem hiding this comment.
Code review — mechanical @cardstack/base/… rename
PR #113 is a consistent find-replace of base-realm module references from the https://cardstack.com/base/… URL form to the @cardstack/base/… prefix across 161 files. The import-path, adoptsFrom, and links.self conversions are internally consistent and match the stated intent (base-prefix RRIs are valid).
The 6 inline comments flag places where the blanket rename either overreached into non-module contexts (a card-instance id in an open-card stack; two boxel search query filters) or left prose/labels describing the old URL form (a column header still titled "URL," intro/explanatory sentences still saying "URL"/"404," and a bare /base/… shorthand). None are blocking. The two "please verify" items — the open-stack card id and the type.module search filters — are worth a quick confirmation against a live realm, since they'd fail silently rather than error.
One load-bearing premise underpins every JSON links.self change (e.g. every Skill/*.json cardInfo.theme): that @cardstack/base/… resolves both as a realm-GTS import specifier and as a stored index ref for relationships. The commit states this was verified against served index documents for relationship ids — worth a final confirmation on a live realm, because if it were wrong the skill cards would silently fail to index.
Generated by Claude Code
`@cardstack/base/…` is a loader-resolved module reference, so describing the catalog's entries as importable from a "stable URL" contradicts cardinal rule 8, which says the prefix is not a fetchable HTTP resource. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`@cardstack/base/…` is a loader-resolved module reference rather than an address the realm-server fetches, so a malformed one fails to resolve — it does not produce a 404. Cardinal rule 8 states the same contract. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Every cell in the column is a `@cardstack/base/…` module reference, so a "URL" header reinforces that the prefix is a fetchable address. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The bare `/base/…` shorthand left the same module written three ways in one sentence, so a reader cannot tell which spelling is canonical. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The stack holds resolved card ids, which the runtime canonicalizes per realm: a realm with a registered prefix yields `@cardstack/base/Author/jane` while one without keeps its absolute form, so the list is a mix of shapes and "URLs" describes only some of them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jurgenwerk
approved these changes
Aug 13, 2026
# Conflicts: # index.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assistant thinks base prefix RRIs are invalid: