Point the blog app's LinkedIn icon at brand-linkedin - #701
Merged
Conversation
boxel-icons no longer ships a `linkedin` icon, so `author.gts` failed to typecheck with TS2307. `brand-linkedin` is the tabler equivalent, and it matches `brand-x` already in use beside it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Staging Submissions PreviewThis PR's content is pushed to the staging submissions realm: https://realms-staging.stack.cards/submissions/ Changed folders:
Updated at 2026-08-19 09:04:58 UTC for commit |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the blog app’s author card to use the currently available Boxel icon module for LinkedIn, unblocking catalog typechecking after the upstream icon set refresh removed the previous linkedin export.
Changes:
- Replaces
@cardstack/boxel-icons/linkedinwith@cardstack/boxel-icons/brand-linkedinin the blog app author card.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lintis failing on every catalog PR with:The monorepo's icon library no longer ships a
linkedinicon — it was dropped when the lucide and tabler sets were refreshed, andbrand-linkedinis the tabler equivalent that survives. Since catalog CI checks outcardstack/boxelmain unpinned, the removal broke the blog app's typecheck without anything changing in this repo.brand-linkedinis a better fit than the icon it replaces: same 24×24 /stroke-width=2/currentColorconventions, and it now matchesbrand-x, whichauthor.gtsalready imports on the next line. Only the module specifier changes — the localLinkedinbinding and its use in the contact-link row are untouched.Scope note
This clears one of two
lint:typesfailures. The other seven errors come from../bxl/src/**(WeakRefunavailable,new Error(msg, { cause })rejected) and are not fixable from this repo:packages/catalog/tsconfig.jsonsetstarget: es2020with nolib, while@cardstack/bxlexports raw.tssource that needs ES2022. That one needs a monorepo-side change.Verification
brand-linkedinexists inpackages/boxel-icons/src/icons/, and the package's./*export maps to a generated declaration, so a fresh build resolves it.@cardstack/boxel-icons/*import across this repo — 100 distinct icons, andlinkedinwas the only casualty of the icon refresh.