Drop the inner container boundary on listing spec items - #700
Merged
Conversation
The listing detail's Includes tab wraps each spec in its own bordered CardContainer, and the spec's fitted field component was drawing a second boundary ring inside it. Pass displayContainer=false so only the outer container draws the border. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Staging Submissions PreviewThis PR's content is pushed to the staging submissions realm: https://realms-staging.stack.cards/submissions/ Changed folders:
Updated at 2026-08-12 07:53:55 UTC for commit |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the “double border” effect in the Listing detail → Includes tab by disabling the inner fitted Spec card’s own container rendering, letting the outer CardContainer be the single visible boundary.
Changes:
- Passes
@displayContainer={{false}}to the dynamically-resolvedSpecComponentwhen rendered in the Includes list. - Keeps existing
CardContainerwrapper and test selectors (data-test-spec-card) intact while adjusting only presentation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
At the fitted minimum of 40px the spec strips read as cramped; 3.5rem give the icon, title, and type tag room to breathe. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
BoxelSelect's onChange passes the selection as T | null, so handlers typed to take a bare T fail ember-tsc. Widen the handlers to accept null and guard, and type the popover playground's option arrays as their literal unions so they match the select's inferred item type. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lukemelia
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
On the listing detail's Includes tab, each spec renders inside a bordered
CardContainer, and the spec's fitted field component draws a second boundary ring of its own just inside it, so every spec row shows a double border. This passes@displayContainer={{false}}to the spec component so only the listing's own container draws the boundary, and gives the rows a 3.5rem minimum height so the strips don't sit at the fitted 40px minimum.The symmetric inline padding visible in the screenshots comes from a companion change to the base Spec card's fitted view in the boxel repo.
Also widens the catalog's
BoxelSelect@onChangehandlers to accept a nullable selection (T | null) and types the popover playground's option arrays as their literal unions, which is whatember-tscrequires against the select's signature.Before
After
Testing
ember-template-lint, Prettier, andember-tsc --noEmitpass over the catalog contentsdata-test-spec-cardselector used by the browse tests is unchanged🤖 Generated with Claude Code