Rename .cmake files when installing to monolith. They need to match whatever was there before#30
Merged
Merged
Conversation
…hatever was there before
Ikreb1
approved these changes
Jul 21, 2026
There was a problem hiding this comment.
Pull request overview
This PR adjusts Trinity’s monolith install behavior so the generated/installed CMake package config filenames are derived from the CMake target name (e.g., trinity_dx11Config.cmake) rather than a separately provided package_name, and simplifies the shared-target setup function accordingly.
Changes:
- Simplified
set_shared_trinity_properties(...)to accept only the target name. - Updated monolith-mode config generation/install to emit
${target}Config.cmake. - Updated all call sites to match the new function signature.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.