Plat 11610 overlay effects on children parts ship#28
Conversation
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v20.1.2
Click here for the full clang-format patch
diff --git a/trinity/Eve/SpaceObject/EveSpaceObject2.h b/trinity/Eve/SpaceObject/EveSpaceObject2.h
index 2b091aa..4e0a9b5 100644
--- a/trinity/Eve/SpaceObject/EveSpaceObject2.h
+++ b/trinity/Eve/SpaceObject/EveSpaceObject2.h
@@ -451 +451,4 @@ public:
- const PEveMeshOverlayEffectVector& GetOverlayEffects() const { return m_overlayEffects; }
+ const PEveMeshOverlayEffectVector& GetOverlayEffects() const
+ {
+ return m_overlayEffects;
+ }
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR extends mesh overlay effect rendering so that overlay effects applied to an EveSpaceObject2 also render on EveChildMesh parts (e.g., ship child meshes), while also refactoring shared overlay batching/area-block collection logic into reusable helper functions.
Changes:
- Exposes
EveSpaceObject2’s overlay effect list via a const accessor for reuse by child meshes. - Refactors overlay area-block collection and overlay batch emission into shared functions (
CollectOverlayAreaBlocks,EmitOverlayBatches). - Implements overlay batch emission for
EveChildMesh, including transparent-batch detection and cached overlay area-block construction.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| trinity/Eve/SpaceObject/EveSpaceObject2.h | Adds a const accessor to expose overlay effects to child meshes. |
| trinity/Eve/SpaceObject/EveSpaceObject2.cpp | Adds null-guard for geometry resource and uses shared overlay batch emission/area-block collection helpers. |
| trinity/Eve/SpaceObject/Children/EveChildMesh.h | Adds state for parent overlay effects and cached overlay area-blocks plus helper declarations. |
| trinity/Eve/SpaceObject/Children/EveChildMesh.cpp | Emits parent overlay effects on child meshes, updates transparent detection, and manages overlay area-block cache. |
| trinity/Eve/SpaceObject/Attachments/EveMeshOverlayEffect.h | Declares shared overlay helper functions for area-block collection and batch emission. |
| trinity/Eve/SpaceObject/Attachments/EveMeshOverlayEffect.cpp | Implements shared overlay helper functions used by both parent and child rendering paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
No description provided.