Add multi-disc game grouping with download-all and .m3u playlists (#17) - #19
Open
caprado wants to merge 1 commit into
Open
Add multi-disc game grouping with download-all and .m3u playlists (#17)#19caprado wants to merge 1 commit into
caprado wants to merge 1 commit into
Conversation
- Introduced a new grouping module with pluggable strategies for catalog entries. - Added `EntryRef`, `Membership`, `GroupingStrategy`, `EntryGroup`, and `GroupMember` classes to define the grouping structure. - Implemented a `DiscStrategy` to recognize multi-disc titles and derive stable keys. - Created a build pass to bucket memberships and promote valid groups based on defined strategies. - Added strategy discovery to load grouping plugins dynamically. - Integrated grouping functionality into the existing build pipeline, allowing for the persistence of grouped entries. - Updated database schema to support entry groups and their members. - Enhanced the download service to handle group downloads and generate `.m3u` playlists for multi-disc sets. - Added tests to ensure correct behavior of grouping logic and strategy recognition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Multi disc games are stored as separate entries with no relationship between them. This adds a grouping layer that relates them, plus a new "Download all discs" button that fetches every disc and writes an
.m3uplaylist.Grouping is done at DB build time zero changes to the core pipeline.
discis the only kind added today.Backwards compatibility
SCHEMA_VERSIONbump.entry_groupstable, so a catalog without grouping degrades instead of erroring.Known limitation
The
.m3ureferences each disc's completed file by basename, correct for the single-file disc image cases. Downloaded/Extracted multi-file discs downloads would need special format handling.