Skip to content

Set SDK_SYSTEMD_SECRET_SOCKET during hook invocation - #997

Open
tlm wants to merge 2 commits into
secrets-implementationfrom
secrets-systemd-socket-env
Open

Set SDK_SYSTEMD_SECRET_SOCKET during hook invocation#997
tlm wants to merge 2 commits into
secrets-implementationfrom
secrets-systemd-socket-env

Conversation

@tlm

@tlm tlm commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Adds SDK_SYSTEMD_SECRET_SOCKET to the environment for all SDK hook
invocations, set to the path of the workshop systemd secret socket.
This allows SDK authors to read the socket location from the environment
rather than hard-coding it, so that the path can change over time
without breaking existing SDKs.

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

  • I confirm the PR has no implications for documentation.

Expose the systemd secret socket path to SDK hooks via the
SDK_SYSTEMD_SECRET_SOCKET environment variable so that SDK authors are
not required to hard-code the socket location and can adapt if it
changes over time.
@tlm tlm self-assigned this Aug 20, 2026
@tlm
tlm requested a review from jonathan-conder August 20, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants