-
Notifications
You must be signed in to change notification settings - Fork 137
docs: tell tutorial readers what to do about the symlink error #2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tonyandrewmeyer
wants to merge
1
commit into
canonical:main
Choose a base branch
from
tonyandrewmeyer:docs/2441-pack-symlink
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't mention destructive mode elsewhere, and people might get sidetracked by that - should they start troubleshooting? I think it's probably better to ask them to delete the dirs, add to the issue, then move on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs suggestion makes sense to me — I agree that mentioning destructive mode there could send tutorial readers down an unnecessary troubleshooting path.
I had a look at canonical/charmcraft#2864 as well. As a Charmcraft-side mitigation, I think the approach is reasonable: ignoring top-level
.venvand.toxprevents the problematic symlinks from reaching the local-source copy path in the first place, so it directly addresses the common reproducer without changing broader source-copy semantics.I would still view it as a mitigation rather than the root fix, though. As you noted, nested virtual environments or an unrelated symlink that triggers the same
llistxattr()/virtiofs behaviour could still fail in craft-parts. So I think merging something like #2864 could be useful in the short term, while separately investigating whether craft-parts should handle this filesystem behaviour more defensively.The root-cause analysis in the PR looks plausible to me, and I would be interested in looking at the craft-parts side as well.