tests: inject ntp configuration through smbios - #466
Open
Meulengracht wants to merge 10 commits into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is coherent, with only a minor non-blocking fixed-string assertion issue.
Pull request overview
Injects backend-provided NTP configuration into nested Ubuntu Core VMs through SMBIOS credentials.
Changes:
- Generates a
tmpfiles.extracredential containing timesyncd configuration. - Verifies the injected NTP and fallback settings.
File summaries
| File | Description |
|---|---|
tests/lib/nested.sh |
Adds SMBIOS credential injection to QEMU startup. |
tests/spread/main/basic/task.yaml |
Validates the generated timesyncd configuration. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Meulengracht
force-pushed
the
feature/ntp-injection
branch
from
September 7, 2026 08:13
4c20720 to
9de7bcd
Compare
…systemd.credential.binary
Meulengracht
requested review from
valentindavid
and
a balanced review from Copilot
September 7, 2026 10:52
valentindavid
approved these changes
Sep 7, 2026
|
|
||
| execute_remote "systemctl status systemd-tmpfiles-setup.service || true" | ||
| execute_remote "sudo journalctl -b -u systemd-tmpfiles-setup.service --no-pager || true" | ||
| execute_remote "sudo journalctl -b -p warning..alert --no-pager | grep -i credential || true" |
Member
There was a problem hiding this comment.
Maybe list /run/credentials/@system
Member
Author
There was a problem hiding this comment.
Thank you for the suggestion! I'm trying to figure out why the check fails in the test :/
| . "$TESTSLIB/nested.sh" | ||
|
|
||
| execute_remote "systemctl status systemd-tmpfiles-setup.service || true" | ||
| execute_remote "sudo journalctl -b -u systemd-tmpfiles-setup.service --no-pager || true" |
Member
There was a problem hiding this comment.
You should add systemd.log_level=debug in the kernel command line.
…k to do it locally
zyga
reviewed
Sep 8, 2026
| cat > "$NTP_SOURCES_FILE" <<EOF | ||
| f+ /etc/chrony/sources.d/10-nested-ntp.sources 0644 - - - ~${NTP_SOURCES_FILE_BASE64} | ||
| EOF | ||
| NTP_SOURCES_FILE_BASE64=$(base64 -w0 "$NTP_SOURCES_FILE") |
Contributor
There was a problem hiding this comment.
this seems to overwrite the previous value set just a few lines above?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.