Skip to content

Fix stale console helper namespace in cakephp60 set #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dereuromark wants to merge 1 commit into
base: 6.x
Choose a base branch
from
+46 −0
Open

Fix stale console helper namespace in cakephp60 set #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions config/rector/sets/cakephp60.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@
$rectorConfig->ruleWithConfiguration(RenameClassRector::class, [
'Cake\Database\DriverFeatureEnum' => 'Cake\Database\Enum\DriverFeature',
'Cake\Http\Cookie\SameSiteEnum' => 'Cake\Http\Cookie\Enum\SameSite',
// Console helpers moved namespace in 5.4, the Cake\Command\Helper namespace is gone in 6.0
'Cake\Command\Helper\BannerHelper' => 'Cake\Console\Helper\BannerHelper',
'Cake\Command\Helper\ProgressHelper' => 'Cake\Console\Helper\ProgressHelper',
'Cake\Command\Helper\TableHelper' => 'Cake\Console\Helper\TableHelper',
'Cake\Command\Helper\TreeHelper' => 'Cake\Console\Helper\TreeHelper',
]);

// Related method rename for SameSite enum
Expand Down Expand Up @@ -97,6 +102,7 @@
'Cake\Collection\Iterator\ZipIterator' => ['_callback', '_iterators'],
],
'Command' => [
// Pre 5.4 location, kept for apps upgrading straight from 5.3 or older
'Cake\Command\Helper\ProgressHelper' => ['_progress', '_total', '_width'],
'Cake\Command\I18nExtractCommand' => [
'_paths', '_files', '_merge', '_file', '_storage', '_tokens', '_translations',
Expand All @@ -105,6 +111,7 @@
'Cake\Command\ServerCommand' => ['_host', '_port', '_documentRoot', '_iniPath'],
],
'Console' => [
'Cake\Console\Helper\ProgressHelper' => ['_progress', '_total', '_width'],
'Cake\Console\TestSuite\ConsoleIntegrationTestTrait' => ['_exitCode', '_out', '_err', '_in'],
'Cake\Console\TestSuite\StubConsoleOutput' => ['_out'],
'Cake\Console\ConsoleInput' => ['_input', '_canReadline'],
Expand Down Expand Up @@ -523,6 +530,7 @@
'Cake\Collection\Iterator\TreePrinter' => ['_fetchCurrent'],
],
'Command' => [
// Pre 5.4 location, kept for apps upgrading straight from 5.3 or older
'Cake\Command\Helper\TreeHelper' => [
'_calculateWidths', '_cellWidth', '_rowSeparator', '_render', '_addStyle',
],
Expand All @@ -541,6 +549,12 @@
],
],
'Console' => [
'Cake\Console\Helper\TreeHelper' => [
'_calculateWidths', '_cellWidth', '_rowSeparator', '_render', '_addStyle',
],
'Cake\Console\Helper\TableHelper' => [
'_calculateWidths', '_cellWidth', '_rowSeparator', '_render', '_addStyle',
],
'Cake\Console\HelpFormatter' => ['_generateUsage', '_getMaxLength'],
'Cake\Console\ConsoleIo' => ['_getInput'],
'Cake\Console\ConsoleOutput' => ['_replaceTags'],
Expand Down
16 changes: 16 additions & 0 deletions tests/test_apps/original/RectorCommand-testApply60/src/ConsoleHelperExample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php
declare(strict_types=1);

namespace MyPlugin;

use Cake\Command\Helper\TableHelper;

class ConsoleHelperExample
{
private TableHelper $Table;

public function render(): void
{
$this->Table->output([['a', 'b']]);
}
}
16 changes: 16 additions & 0 deletions tests/test_apps/upgraded/RectorCommand-testApply60/src/ConsoleHelperExample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php
declare(strict_types=1);

namespace MyPlugin;

use Cake\Command\Helper\TableHelper;

class ConsoleHelperExample
{
private \Cake\Console\Helper\TableHelper $Table;

public function render(): void
{
$this->Table->output([['a', 'b']]);
}
}
Loading