Fixed rate command - #64
Open
qarkai wants to merge 5 commits into
Open
Conversation
2 similar comments
byroot
reviewed
Oct 23, 2016
byroot
left a comment
byroot
left a comment
Owner
There was a problem hiding this comment.
I'm not sure I understand why this way would be more logical than the previous one.
| return self.from_ordinal(int(round(self.ordinal / ratio))) | ||
|
|
||
| def __itruediv__(self, ratio): | ||
| self.ordinal = int(round(self.ordinal / ratio)) |
Owner
There was a problem hiding this comment.
Why not call __idiv__ instead of copying the code?
Author
|
The more framerate the less time value should be because there will be more text per second. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ratio is
final/initialthen time should be divided by it, not multiplied.