Add appearance override setting (System / Light / Dark) (Closes #600) - #660
Open
ameerhmz wants to merge 1 commit into
Open
Add appearance override setting (System / Light / Dark) (Closes #600)#660ameerhmz wants to merge 1 commit into
ameerhmz wants to merge 1 commit into
Conversation
Owner
|
Hello, please fill out the mandatory information that has to be included with every pull request : Mandatory InformationAI / LLM UseDid you use any AIs / LLMs to create any part of this pull request?
If Yes — How was it used? (mandatory)I used LLMs to... |
Author
|
Hi @buresdv! I have updated the PR description to include the mandatory AI disclosure section as requested. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #600 by adding a user setting in Settings -> General to override the app's appearance mode:
Changes
AppearanceOverrideenum inCorkSharedmodule.customAppearancedefault setting key inGeneral Settings.swift.General Pane.swift..preferredColorScheme(Defaults[.customAppearance].colorScheme)modifier toContentView.Mandatory Information
AI / LLM Use
Did you use any AIs / LLMs to create any part of this pull request?
If Yes — How was it used? (mandatory)
I used LLMs to help structure the
AppearanceOverrideenum inCorkSharedand integrate the.preferredColorSchememodifier inContentView.swift.