fix(web): disable select inputs and show loading state during async fetch - #148
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the
selectform component where typing was allowed while the field was in a loading state (isLoading === true). This mismatch caused autocomplete matching to break once the new options finished loading.It also introduces a soft, visually elegant pulsating background animation (
animate-pulse bg-muted/40) and changes the placeholder text dynamically to"..."while options are loading, providing a premium, language-neutral visual loading cue.Key Changes
Docs / Web (
apps/web)ComboboxChipsInputandComboboxInput) whenisLoadingis true."..."during load to avoid translation overhead.animate-pulse bg-muted/40) toComboboxChipsandComboboxInputduring loading state.Type of change
fix(Bug fix)Related Issues