Skip to content

fix: link verbosity to logging level - #299

Merged
frostming merged 1 commit into
bubbuild:mainfrom
kemingy:fix/verbose-log-level
Sep 8, 2026
Merged

fix: link verbosity to logging level#299
frostming merged 1 commit into
bubbuild:mainfrom
kemingy:fix/verbose-log-level

Conversation

@kemingy

@kemingy kemingy commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • map BUB_VERBOSE values to Loguru levels: 0INFO, 1DEBUG, and 2TRACE
  • configure both the stderr and optional Logfire sinks with the selected level
  • load settings after BubFramework loads the YAML configuration, so file and environment settings are respected

Why

Loguru defaults new sinks to DEBUG, which made Bub print the optional Logfire import diagnostic during normal CLI startup. The existing verbose setting was not connected to logging.

Verification

  • make check
  • uv run pytest -q tests/test_cli_help.py tests/test_settings.py (14 passed)
  • make test (330 passed, 1 skipped, 4 unrelated existing failures in tests/test_install_scripts.py because website/public/install.sh expands an unset EXTRA_DEPENDENCIES array under macOS /bin/bash)
  • tox not run locally; the contribution guide notes that CI runs the Python version matrix

@frostming
frostming merged commit b066800 into bubbuild:main Sep 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants