Skip to content

Fix Tags table scroll staying disabled after backgrounding #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvanhorn wants to merge 1 commit into from
Closed

Fix Tags table scroll staying disabled after backgrounding #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/iOS/CustomViews/AutocompleteTextField.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ class AutocompleteTextField: UITextField, UITableViewDataSource, UITableViewDele
selector: #selector(keyboardWillChange(_:)),
name: UIResponder.keyboardWillChangeFrameNotification,
object: nil)
NotificationCenter.default.addObserver(
self,
selector: #selector(appWillResignActive(_:)),
name: UIApplication.willResignActiveNotification,
object: nil)

addTarget(self, action: #selector(editingChanged), for: .editingChanged)
addTarget(self, action: #selector(editingEnded), for: .editingDidEnd)
Expand Down Expand Up @@ -121,6 +126,12 @@ class AutocompleteTextField: UITextField, UITableViewDataSource, UITableViewDele
}
}

@objc func appWillResignActive(_ nsNotification: Notification) {
guard !filteredCompletions.isEmpty else { return }

clearFilteredCompletionsInternal()
}

func frameForCompletionTableView() -> CGRect {
guard let cell = superviewOfType(UITableViewCell.self),
let tableView = cell.superviewOfType(UITableView.self)
Expand Down Expand Up @@ -256,6 +267,15 @@ class AutocompleteTextField: UITextField, UITableViewDataSource, UITableViewDele

@objc private func editingEnded() {
clearFilteredCompletionsInternal()

// Defensively restore scrolling: if the overlay teardown path was
// skipped (e.g. the app resigned active while completions showed),
// the enclosing table would otherwise stay unscrollable.
if let cell = superviewOfType(UITableViewCell.self),
let tableView = cell.superviewOfType(UITableView.self)
{
tableView.isScrollEnabled = true
}
}

override func paste(_ sender: Any?) {
Expand Down
Loading