Skip to content

Improved imports. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KsaR99 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Improved imports. #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecc33d9
Improved imports
KsaR99 Sep 3, 2026
4028708
Revert file
KsaR99 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Actions/ProcessDiskVault.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ private function processDirectory(
$attributes['is_file'] = true;
$attributes['name'] = $pathInfo['filename'];
$attributes['extension'] = $pathInfo['extension'] ?? 'md';
$attributes['content'] = (string) file_get_contents("/$file");
$attributes['content'] = (string) file_get_contents($file);

@KsaR99 KsaR99 Sep 3, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows failed on test without it

$createVaultNode->handle($vault, $attributes, false);
}
}
Expand Down
10 changes: 2 additions & 8 deletions app/Actions/UpdateVaultNodeBacklinks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,8 @@ public function handle(VaultNode $node, string $originalLinkPath, ?string $repla
return;
}

if ($replacementLinkPath === null) {
/**
* @var string $replacementLinkPath
*
* @phpstan-ignore-next-line larastan.noUnnecessaryCollectionCall
*/
$replacementLinkPath = $node->ancestorsAndSelf()->get()->last()->full_path;
}
/** @var string $replacementLinkPath */
$replacementLinkPath ??= $node->ancestorsAndSelf()->get()->last()->full_path;

@KsaR99 KsaR99 Sep 3, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rector suggested this change.


$originalLinkPattern = '\/?'
. str_replace(' ', '\s', preg_quote($originalLinkPath, '/'))
Expand Down
12 changes: 6 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
"license": "MIT",
"require": {
"php": "^8.4",
"inertiajs/inertia-laravel": "^3.3.1",
"laravel/framework": "^13.29.0",
"inertiajs/inertia-laravel": "^3.3.2",
"laravel/framework": "^13.30.1",
"laravel/reverb": "^1.11.1",
"laravel/scout": "^11.6.1",
"laravel/socialite": "^5.30.1",
"laravel/socialite": "^5.31.0",
"laravel/tinker": "^3.0.2",
"laravel/wayfinder": "^0.1.21",
"socialiteproviders/auth0": "^4.2",
Expand All @@ -27,17 +27,17 @@
"typesense/typesense-php": "^6.0"
},
"require-dev": {
"barryvdh/laravel-debugbar": "^4.4.2",
"barryvdh/laravel-debugbar": "^4.4.3",
"fakerphp/faker": "^1.24.1",
"larastan/larastan": "^3.10.0",
"larastan/larastan": "^3.11.0",
"laravel/pint": "^1.30.5",
"laravel/sail": "^1.67.0",
"mockery/mockery": "^1.6.15",
"nunomaduro/collision": "^8.9.5",
"pestphp/pest": "^5.1.3",
"pestphp/pest-plugin-browser": "^5.0",
"pestphp/pest-plugin-type-coverage": "^5.0",
"rector/rector": "^2.6.3",
"rector/rector": "^2.6.6",
"squizlabs/php_codesniffer": "^4.0.4"
},
"autoload": {
Expand Down
Loading