Add eslint rules and tests - #439
Draft
arogl wants to merge 97 commits into
Draft
Conversation
follow existing style.
Less noise.
- Can put "enable" or "disable" in description instead of messages. - Can omit "_enabled" from js code to shorten code lines.
"document.scrollingElement" has been widely used since 2016.
Cleanup, reorganization, encapsulation.
arogl
changed the title
Contributor
We can make this PR a draft for now. |
arogl
marked this pull request as draft
August 12, 2026 09:01
pzhlkj6612
suggested changes
Aug 13, 2026
Contributor
There was a problem hiding this comment.
Really, have a look at your git-diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following comments in #436, I have implemented a large number of eslint rules based on Google JS Guide
I have also added some tests.
This PR needs to be pulled AFTER #436, but happy to keep both PRs updated