fix(logger): honor internal BTQL dataset limits - #658
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoAug 5, 2026
Merged
fix(logger): honor internal BTQL dataset limits#658Abhijeet Prasad (AbhiPrasad) merged 2 commits into
Abhijeet Prasad (AbhiPrasad) merged 2 commits into
Conversation
BTQL applies limit per page, so ObjectFetcher kept following cursors and returned more records than users requested. This caused evaluations and other consumers relying on a bounded dataset size to process unexpected records. Stop after the cumulative limit, truncate excess results, and skip API work for a zero limit. Add VCR-backed pagination coverage and a focused zero-limit test.
Provide a dummy API key so the regression test reaches the recorded login request when CI runs without BRAINTRUST_API_KEY. Local runs previously passed only because a developer credential was present in the environment.
Luca Forstner (lforst)
approved these changes
Aug 5, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi-fix-cap-internal-btql-dataset-results
branch
August 5, 2026 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/braintrustdata/issue/SDK-200/python-dataset-returns-more-records-than-specified-in-internal-btql
BTQL applies limit per page, so ObjectFetcher kept following cursors and returned more records than users requested. This caused evaluations and other consumers relying on a bounded dataset size to process unexpected records.
Stop after the cumulative limit, truncate excess results, and skip API work for a zero limit.