fix(dataset): enforce cumulative btql fetch limits - #2344
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoAug 5, 2026
Conversation
The object fetcher treated `_internal_btql.limit` as a per-request page size instead of a total result cap. It yielded every response and kept following cursors, so fully consuming a dataset or calling `fetchedData()` could return more records than requested. Before: limit=3 -> page(2, cursor) -> page(2) -> 4 rows After: limit=3 -> page(2, cursor) -> page(limit=1) -> 3 rows Track the remaining record budget across requests, cap each page by both the batch size and that budget, and stop yielding or paginating when it is exhausted. Add fake API coverage for cursor termination, oversized responses, and the interaction between `batchSize` and the cumulative limit.
Luca Forstner (lforst)
approved these changes
Aug 5, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi-fix-enforce-dataset-btql-limit
branch
August 5, 2026 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/braintrustdata/issue/SDK-201/javascript-dataset-returns-more-records-than-specified-in-internal
The object fetcher treated
_internal_btql.limitas a per-request page size instead of a total result cap. It yielded every response and kept following cursors, so fully consuming a dataset or callingfetchedData()could return more records than requested.Before: limit=3 -> page(2, cursor) -> page(2) -> 4 rows
After: limit=3 -> page(2, cursor) -> page(limit=1) -> 3 rows
Track the remaining record budget across requests, cap each page by both the batch size and that budget, and stop yielding or paginating when it is exhausted. Add fake API coverage for cursor termination, oversized responses, and the interaction between
batchSizeand the cumulative limit.