fix(activity-sidebar): remove UAA parity logging#4719
Merged
mergify[bot] merged 1 commit intoJul 23, 2026
Conversation
Contributor
WalkthroughThe feed flow now uses UAA file activities directly when enabled, skips V2 feed API calls, removes parity logging, updates sidebar feature-flag wiring, and replaces the removed parity metric with explicit metric constants and types. ChangesUAA Feed Flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ActivitySidebar
participant FeedAPI
participant UAAFileActivities
ActivitySidebar->>FeedAPI: call feedItems with UAA flags
FeedAPI->>UAAFileActivities: fetch file activities
UAAFileActivities-->>FeedAPI: return activities
FeedAPI->>FeedAPI: parse and handle feed items
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ions service traffic
kduncanhsu
force-pushed
the
kduncanhsu/remove-uaa-parity-logging
branch
from
July 23, 2026 21:14
1596889 to
6a95178
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/api/Feed.js (1)
614-627: 🚀 Performance & Scalability | 🔵 TrivialVerify the traffic reduction before rollout.
Confirm in preview and post-deployment metrics that legacy annotation, comment, task, app-activity, and version requests remain absent for UAA-enabled loads, while
file_activitiessuccess rates remain healthy.As per PR objectives, preview validation and post-deployment traffic verification remain pending.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/api/Feed.js` around lines 614 - 627, Validate the UAA request gating around annotationsPromise, commentsPromise, tasksPromise, appActivityPromise, versionsPromise, and currentVersionPromise in preview and after deployment: confirm these legacy requests are absent for UAA-enabled loads, and verify file_activities success rates remain healthy before completing rollout.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/api/Feed.js`:
- Around line 614-627: Validate the UAA request gating around
annotationsPromise, commentsPromise, tasksPromise, appActivityPromise,
versionsPromise, and currentVersionPromise in preview and after deployment:
confirm these legacy requests are absent for UAA-enabled loads, and verify
file_activities success rates remain healthy before completing rollout.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: af7cc76a-a6fb-452a-b983-1a8628d07132
📒 Files selected for processing (7)
src/api/Feed.jssrc/api/__tests__/Feed.test.jssrc/common/types/logging.jssrc/constants.jssrc/elements/common/logger/Logger.jssrc/elements/content-sidebar/ActivitySidebar.jssrc/elements/content-sidebar/__tests__/ActivitySidebar.test.js
💤 Files with no reviewable changes (3)
- src/constants.js
- src/elements/content-sidebar/ActivitySidebar.js
- src/elements/content-sidebar/tests/ActivitySidebar.test.js
🚧 Files skipped from review as they are similar to previous changes (1)
- src/elements/common/logger/Logger.js
jmcbgaston
approved these changes
Jul 23, 2026
JChan106
approved these changes
Jul 23, 2026
tjuanitas
approved these changes
Jul 23, 2026
Contributor
Merge Queue Status
This pull request spent 11 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compareV2AndUaaFeedItemsparity check that fired the full legacy v2 API fan-out (comments, annotations, tasks, versions, app activity) on every preview load when UAA was enabled, solely for comparison logging!shouldUseUAAso they are never fired when the UAA/file_activitiesendpoint is in useMETRIC_TYPE_UAA_PARITY_METRICconstant and associated logging infrastructure (logAPIParity, Logger special case)Context
When
activityFeed.uaaIntegration.enabledis on, the sidebar renders from the UAA response but still fired ~6 legacy API calls per preview load for parity validation. This added ~12.6MgetCommentscalls/day to the annotations service (~2x its total volume). Parity has been validated and is no longer needed.The original PR which added UAA parity logging is: #3629
Test plan
yarn test src/api/__tests__/Feed.test.js— 138 tests passyarn test src/elements/content-sidebar/__tests__/ActivitySidebar.test.js— 133 tests passyarn test src/elements/common/logger/__tests__/Logger.test.js— 10 tests passyarn flow checkpasses on modified filesSummary by CodeRabbit