Avoid deprecated spl_object_hash() on PHP 8.6 - #300
Open
andypost wants to merge 1 commit into
Open
Conversation
PHP 8.6 deprecates spl_object_hash() in favor of spl_object_id(). Use spl_object_id() where available and cast to string to preserve getResourceId()'s documented return value. The fallback keeps support for PHP 7.1, where spl_object_id() does not exist. Fixes bovigo#299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.6 deprecates spl_object_hash() in favor of spl_object_id().
Use spl_object_id() where it is available and cast the ID to string to preserve getResourceId()'s documented return value. The function_exists() fallback keeps support for PHP 7.1, where spl_object_id() does not exist.
Same change for the master branch: the companion PR targets 2.x without the fallback.
Fixes #299