Link zlib statically via libz-sys - #7
Merged
Conversation
Replace the redundant `.static_flag(true)` calls in the cc build scripts with an explicit `libz-sys` dependency (with the `static` feature), ensuring zlib is properly linked for version1.
atlowChemi
force-pushed
the
fix/static-zlib-linking
branch
from
April 13, 2026 10:23
de9bd31 to
9cd69b8
Compare
Member
|
Thank you! What is the context? You found the build failing in some environment due to |
IvanUkhov
reviewed
Apr 14, 2026
IvanUkhov
reviewed
Apr 14, 2026
Contributor
Author
Yes, I was trying to build cross-platform for a napi.rs addon, it was failing when trying to build with cargo-xwin |
Contributor
Author
|
Thanks @IvanUkhov! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.static_flag(true)calls from allcc::Buildblocks inbuild.rs— thecccrate already produces static.aarchives, so the flag was a no-oplibz-syswithfeatures = ["static"]toCargo.tomlto ensure zlib is statically linkeduse libz_sys as _insrc/lib.rsto guarantee the linker includes the static zlib forversion1