Fix unsoundness in JsValueStore by replacing unsafe raw pointer mutation of Arc with safe OnceLock - #5408
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5408 +/- ##
===========================================
+ Coverage 47.24% 62.81% +15.57%
===========================================
Files 476 530 +54
Lines 46892 59108 +12216
===========================================
+ Hits 22154 37130 +14976
+ Misses 24738 21978 -2760 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hansl
left a comment
There was a problem hiding this comment.
Why is the macro change part of this PR? Feels like it should be its own PR, can you split them?
…ion of Arc with safe OnceLock
15efccc to
09cb647
Compare
|
Thanks for the review, @hansl. |
Fix the unused-async-trait-impl and useless-format clippy lints introduced by the Rust 1.98 stable toolchain in existing ModuleLoader and Fetcher implementations.
This Pull Request fixes/closes #5392.
It changes the following: